Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(engine): complete cleanup of ast_utils #442

Closed
wants to merge 1 commit into from

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Jan 18, 2024

AST utils used to be one monolithic file without good organization and with no documentation at all.

This commit drops ast_utils.ml in favor of ast_utils/* modules, and reoganize things.

I intend on documenting everything in ast_utils/*.

STATUS:
Before #504, this PR was adding even more functor instantiation all over the place, creating again a lot more visitors, making things even slower and more painful.
But now, I should be able to rebase that PR!

AST utils used to be one monolithic file without good organization and
with no documentation at all.

This commit drops `ast_utils.ml` in favor of `ast_utils/*` modules,
and reoganize things.

I intend on documenting everything in `ast_utils/*`.
@franziskuskiefer franziskuskiefer added the waiting-on-author Status: This is awaiting some action from the author. label Feb 29, 2024
@W95Psp W95Psp linked an issue Apr 11, 2024 that may be closed by this pull request
@W95Psp W95Psp closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author Status: This is awaiting some action from the author.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Engine: refactor the module ast_utils
2 participants